[IMP] color picker: add eye dropper support#8737
Closed
hokolomopo wants to merge 2 commits into
Closed
Conversation
Collaborator
|
|
hokolomopo
force-pushed
the
master-eye-dropper-adrm
branch
from
1c768c4 to
046a04f
Compare
VincentSchippefilt
force-pushed
the
master
branch
from
7488c1c to
ebf0f6f
Compare
pro-odoo
reviewed
May 19, 2026
hokolomopo
force-pushed
the
master-eye-dropper-adrm
branch
from
046a04f to
b9ac93f
Compare
Collaborator
|
this will need to be documented as Chrome only as it's not even in the path of becoming a standard https://wicg.github.io/eyedropper-api/ |
rrahir
reviewed
May 19, 2026
| } | ||
| } catch (error) { | ||
| if (error.name !== "AbortError") { | ||
| console.error("Error using the eye dropper:", error); |
Collaborator
There was a problem hiding this comment.
a silent fail will not be that helpful. what can go wrong ?
Contributor
Author
There was a problem hiding this comment.
AbortError is not really an error, it's when you press escape to abort the color picking. Skipping those make sense.
I guess I could throw the other errors instead of logging then in the console tho
rrahir
reviewed
May 19, 2026
hokolomopo
force-pushed
the
master-eye-dropper-adrm
branch
from
b9ac93f to
fc05188
Compare
Collaborator
|
robodoo r+ |
Collaborator
|
@hokolomopo @rrahir because this PR has multiple commits, I need to know how to merge it:
|
Collaborator
|
robodoo r- |
hokolomopo
force-pushed
the
master-eye-dropper-adrm
branch
from
fc05188 to
b3ce441
Compare
LucasLefevre
approved these changes
Jun 3, 2026
| } | ||
|
|
||
| get canUseEyeDropper(): boolean { | ||
| return !!globalThis.EyeDropper && !this.env.model.getters.isDarkMode(); |
Collaborator
There was a problem hiding this comment.
dark mode 😢
Worth a comment saying why it cannot work in in dark mode
Comment on lines
+225
to
+226
| // In dark mode we'd have to do the opposite color inversion than then dark mode color inversion to get the correct color. | ||
| // But this mathematically cannot always be done, because our color inversion lose information with clipping and rounding. |
Collaborator
There was a problem hiding this comment.
👍
move or copy/paste this comment in the business code
- `globalThis.Chart` was defined twice - `ChartGeo` was defined in `window` instead of `globalThis` Task: 6226285
LucasLefevre
force-pushed
the
master-eye-dropper-adrm
branch
from
b3ce441 to
eab48da
Compare
Collaborator
|
rebased + comment added |
Collaborator
|
@hokolomopo @LucasLefevre 'ci/runbot' failed on this reviewed PR. |
This commit adds a button to pick a color from anywhere on your screen using the EyeDropper API. The EyeDropper API is still experimental and not widely supported (only on desktop chromium browser at the time of writing this), so we make sure the button is only there when the API is avilable. Task: 6226285
LucasLefevre
force-pushed
the
master-eye-dropper-adrm
branch
from
eab48da to
91479ce
Compare
Collaborator
|
robodoo r+ |
Collaborator
|
robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jun 6, 2026
- `globalThis.Chart` was defined twice - `ChartGeo` was defined in `window` instead of `globalThis` Task: 6226285 Part-of: #8737 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jun 6, 2026
This commit adds a button to pick a color from anywhere on your screen using the EyeDropper API. The EyeDropper API is still experimental and not widely supported (only on desktop chromium browser at the time of writing this), so we make sure the button is only there when the API is avilable. closes #8737 Task: 6226285 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] color picker: add eye dropper support
This commit adds a button to pick a color from anywhere on your
screen using the EyeDropper API.
The EyeDropper API is still experimental and not widely supported
(only on desktop chromium browser at the time of writing this),
so we make sure the button is only there when the API is avilable.
[IMP] typing: improve
globalThistypingglobalThis.Chartwas defined twiceChartGeowas defined inwindowinstead ofglobalThisTask: 6226285
review checklist